Skip to content

Fix keyboard shortcut conflicts - #14704

Open
bnquon wants to merge 4 commits into
zen-browser:devfrom
bnquon:fix/keyboard-shortcut-conflicts
Open

Fix keyboard shortcut conflicts#14704
bnquon wants to merge 4 commits into
zen-browser:devfrom
bnquon:fix/keyboard-shortcut-conflicts

Conversation

@bnquon

@bnquon bnquon commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

when setting a shortcut that is already being used, it now asks if you want to move it to the new action.

if you choose Move shortcut, the shortcut is cleared from the old action and assigned to the new one. choosing Cancel leaves both actions unchanged.

inspired by @EXOTARA's approach in the original issue's thread.

(Since filming demo i updated the capitalization of the dialog title and action)

zen-issue-14492-demo.mp4

testing

  • tested moving a conflicting shortcut
  • tested cancelling the prompt and confirmed both shortcuts stayed unchanged
  • checked that the shortcut changes were saved after restarting Zen and opening a new Settings tab
  • tested on macOS

note

there seems to be an existing issue where restored Settings tabs show stale shortcut values after restarting Zen. closing the restored Settings tab and opening a new one shows the correct saved values. I was also able to reproduce this with normal non-conflicting shortcut changes on the dev branch, so it doesn’t appear to be related to this change.

Closes #14492


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@bnquon
bnquon requested a review from mr-cheffy as a code owner July 25, 2026 00:31
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-intuitive shortcut mapping

1 participant