gh-14317: Show pinned-tab scroll-shadow dividers based on scroll position - #14560
gh-14317: Show pinned-tab scroll-shadow dividers based on scroll position#14560daberni wants to merge 2 commits into
Conversation
…scroll position The top/bottom scroll-shadow dividers were derived from the arrowscrollbox's scrolledtostart/scrolledtoend, which it computes from the first/last scrollable element's edge. With collapsed pinned tabs those edges are unreliable, so the divider either flashed at the top (when pinned tabs were counted) or only appeared once scrolled past the pinned/normal separator (when excluded).
dosubot
Bot
added
size:S
|
I feel like you already opened a similar PR to this? As I explained last time, we don't plan on fixing this, the overhead doesn't seem to be worth it for this minor issue |
@mr-cheffy You are right, but this approach is now really clean an minimal. Also restoring the same behaviour as Arc is showing. The duplicate divider on collapsed Workspaces is really annoying me :D |
mr-cheffy
left a comment
mr-cheffy
left a comment
There was a problem hiding this comment.
This all seems to be super AI generated....
why do you think so? which part of the code does not meet your standards, or what is your issue exactly? 🧐 I am happy to address any concerns |
2 participants
The top/bottom scroll-shadow dividers were derived from the arrowscrollbox's scrolledtostart/scrolledtoend, which it computes from the first/last scrollable element's edge. With collapsed pinned tabs those edges are unreliable, so the divider either flashed at the top (when pinned tabs were counted) or only appeared once scrolled past the pinned/normal separator (when excluded).