chore(tests): clean up "passed" logging in integration tests - #355
Merged
Conversation
mnoah1
marked this pull request as ready for review
July 14, 2026 15:15
mnoah1
enabled auto-merge
July 14, 2026 15:21
sbalabanov
approved these changes
Jul 20, 2026
sbalabanov
left a comment
sbalabanov
left a comment
Contributor
There was a problem hiding this comment.
e2e/integration test logger also prints time elapsed since the previous run of the logger, so sometimes could be useful for debugging
probably not in these cases though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Bazel already reports pass/fail outcome on test cases - logging that a test case passed is redundant
What?
Remove logging at the end of tests that just log "passed"
Test Plan