fix(run-engine,webapp): return unclaimed runs to the queue when pausing - #4398
Open
matt-aitken wants to merge 4 commits into
Open
fix(run-engine,webapp): return unclaimed runs to the queue when pausing#4398matt-aitken wants to merge 4 commits into
matt-aitken wants to merge 4 commits into
Conversation
Pausing a queue or environment set its concurrency limit to 0, which stops the queue admitting new runs but does nothing about runs it had already admitted. Those runs sit in a per-region worker queue that supervisors drain with a plain BLPOP, with no pause or concurrency check on the pop path, so they went on to execute during the pause. An idle environment with headroom can have its whole concurrency limit's worth of runs in that state, since the trigger-time fast path pushes straight to the worker queue. Adds RunQueue.returnUnclaimedMessagesToQueue, which moves runs the queue has admitted but no worker has claimed yet back into the pending queue. Candidates come from the difference between currentConcurrency and currentDequeued, which identifies worker queue residents without scanning the region-wide list. Each move runs in a Lua script whose LREM doubles as the claim: if it removes nothing then a worker already owns that run and every other key is left alone, so a concurrent BLPOP can never produce a duplicate dispatch. Ordering is preserved by re-adding at the message's original timestamp rather than a fresh score the way nack does, so a returned run keeps its place in line. Callers must set the concurrency limit to 0 first: returning a run costs it its position in the worker queue FIFO and it can only re-enter at the back, so a queue that can still admit work could let a newer run overtake one on its way back. All three pause callers already do this ordering. Covers the manual queue pause, the manual environment pause, and the billing-limit environment pause.
|
Contributor
WalkthroughThe change adds 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e3b9a597-ea2b-4e48-8bb8-0f92b4e4acd5
📒 Files selected for processing (10)
.server-changes/pause-returns-waiting-runs.mdapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-engine/src/run-queue/index.tsinternal-packages/run-engine/src/run-queue/tests/dequeueMessageFromWorkerQueue.test.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (17)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (12, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (11, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 12)
- GitHub Check: typecheck / typecheck
- GitHub Check: internal / 🧪 Unit Tests: Internal
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: runops-guard / runops-guard
- GitHub Check: code-quality / code-quality
🧰 Additional context used
📓 Path-based instructions (13)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
**/*.{ts,tsx}: Prefer static imports over dynamicimport(); use dynamic imports only for unresolvable circular dependencies, genuine performance code splitting, or conditional runtime loading.
Import Trigger.dev tasks from@trigger.dev/sdk; never use@trigger.dev/sdk/v3or deprecatedclient.defineJob.
Add agentcrumbs while writing code using approved namespaces; mark lines with//@Crumbsor blocks with `// `#region` `@crumbs, and strip them before merging.
Files:
internal-packages/run-engine/src/run-queue/tests/dequeueMessageFromWorkerQueue.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/engine/index.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.tsinternal-packages/run-engine/src/run-queue/index.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
Files:
internal-packages/run-engine/src/run-queue/tests/dequeueMessageFromWorkerQueue.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/engine/index.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.tsinternal-packages/run-engine/src/run-queue/index.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
**/*.{test,spec}.{ts,tsx}: Use Vitest exclusively and never mock dependencies; use Testcontainers for integration dependencies.
Place test files next to the source files they test.
Files:
internal-packages/run-engine/src/run-queue/tests/dequeueMessageFromWorkerQueue.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
internal-packages/run-engine/src/run-queue/tests/dequeueMessageFromWorkerQueue.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/engine/index.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.tsinternal-packages/run-engine/src/run-queue/index.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts
internal-packages/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
For internal packages, use
typecheckfor verification and never usebuildas the correctness check.
Files:
internal-packages/run-engine/src/run-queue/tests/dequeueMessageFromWorkerQueue.test.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-engine/src/run-queue/index.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: Access environment variables through theenvexport ofenv.server.tsinstead of directly accessingprocess.env
Use subpath exports from@trigger.dev/corepackage instead of importing from the root@trigger.dev/corepathDo not reintroduce the removed v1 execution path;
RunEngineVersion.V1branches may only reject or finalize gracefully so v3 clients receive a clean 4xx, never a 5xx.
Files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
apps/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
For apps, use
typecheckfor verification and never usebuildas the correctness check.
Files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
apps/webapp/app/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
apps/webapp/app/**/*.{ts,tsx}: For dashboard changes, visually verify the running Remix app with Chrome DevTools MCP, using snapshots, screenshots, interaction, and console-message checks as appropriate.
UseuseCallbackanduseMemoonly for context provider values, expensive derived data used as a dependency, or stable references required by dependency arrays; do not wrap ordinary event handlers or trivial computations.
Use named constants for sentinel or placeholder values instead of scattering raw string literals across comparisons.
Files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
apps/webapp/app/**/*.ts
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
apps/webapp/app/**/*.ts: Never userequest.signalto detect client disconnects. UsegetRequestAbortSignal()fromapp/services/httpAsyncStorage.server.ts, which is wired to Express response close events.
Access environment variables through theenvexport fromapp/env.server.ts; never useprocess.envdirectly.
Always use PrismafindFirstinstead offindUnique.
Always use the$transactionhelper from~/db.server, never callprisma.$transactionor$replica.$transactiondirectly. Pass isolation levels as strings, useSerializablefor correctness-critical read-then-write invariants, and guard possibly undefined helper results when a definite value is required.
Files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
apps/webapp/app/v3/**/*.ts
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
New code must target Run Engine V2 through the singleton in
app/v3/runEngine.server.ts; do not reintroduce V1 execution paths. V1 branches may only reject or finalize gracefully with a clean 4xx.
Files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
apps/webapp/**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
Do not import
env.server.tsdirectly or indirectly into test files; instead pass environment-dependent values through options/parameters to make code testable
Files:
apps/webapp/test/billingLimitConvergeEnvironments.test.ts
apps/webapp/**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
Test files must not import
app/env.server.ts; pass configuration as options instead.
Files:
apps/webapp/test/billingLimitConvergeEnvironments.test.ts
🧠 Learnings (23)
📚 Learning: 2026-05-14T14:54:39.095Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3545
File: .server-changes/agent-view-sessions.md:10-10
Timestamp: 2026-05-14T14:54:39.095Z
Learning: In the `trigger.dev` repository, do not flag inconsistent dot vs slash notation in route/path strings inside `.server-changes/*.md` files. These markdown files are consumed verbatim into the changelog, so the mixed notation (e.g., `resources.orgs.../runs.$runParam/...`) is intentional and should be preserved as-is.
Applied to files:
.server-changes/pause-returns-waiting-runs.md
📚 Learning: 2026-07-26T13:14:02.968Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 4378
File: .server-changes/realtime-run-reads-from-primary.md:0-0
Timestamp: 2026-07-26T13:14:02.968Z
Learning: For files in the .server-changes directory, the body text is published verbatim as dashboard-facing user release notes. Write entries in terms of user-visible behavior (what users can do/see), and avoid implementation-oriented details such as environment-variable names, internal mechanisms, or configuration knobs. If you need to include operational/configuration specifics, put those details in the PR description instead of the .server-changes entry.
Applied to files:
.server-changes/pause-returns-waiting-runs.md
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
internal-packages/run-engine/src/run-queue/tests/dequeueMessageFromWorkerQueue.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/engine/index.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.tsinternal-packages/run-engine/src/run-queue/index.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
internal-packages/run-engine/src/run-queue/tests/dequeueMessageFromWorkerQueue.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/engine/index.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.tsinternal-packages/run-engine/src/run-queue/index.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
internal-packages/run-engine/src/run-queue/tests/dequeueMessageFromWorkerQueue.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/engine/index.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.tsinternal-packages/run-engine/src/run-queue/index.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
internal-packages/run-engine/src/run-queue/tests/dequeueMessageFromWorkerQueue.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/engine/index.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.tsinternal-packages/run-engine/src/run-queue/index.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
internal-packages/run-engine/src/run-queue/tests/dequeueMessageFromWorkerQueue.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/engine/index.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.tsinternal-packages/run-engine/src/run-queue/index.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
internal-packages/run-engine/src/run-queue/tests/dequeueMessageFromWorkerQueue.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/engine/index.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.tsinternal-packages/run-engine/src/run-queue/index.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
internal-packages/run-engine/src/run-queue/tests/dequeueMessageFromWorkerQueue.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/engine/index.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.tsinternal-packages/run-engine/src/run-queue/index.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
internal-packages/run-engine/src/run-queue/tests/dequeueMessageFromWorkerQueue.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
internal-packages/run-engine/src/run-queue/tests/dequeueMessageFromWorkerQueue.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/engine/index.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.tsinternal-packages/run-engine/src/run-queue/index.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
internal-packages/run-engine/src/run-queue/tests/dequeueMessageFromWorkerQueue.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/engine/index.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.tsinternal-packages/run-engine/src/run-queue/index.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
internal-packages/run-engine/src/run-queue/tests/dequeueMessageFromWorkerQueue.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts
📚 Learning: 2026-03-10T17:56:20.938Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3201
File: apps/webapp/app/v3/services/setSeatsAddOn.server.ts:25-29
Timestamp: 2026-03-10T17:56:20.938Z
Learning: Do not implement local userId-to-organizationId authorization checks inside org-scoped service classes (e.g., SetSeatsAddOnService, SetBranchesAddOnService) in the web app. Rely on route-layer authentication (requireUserId(request)) and org membership enforcement via the _app.orgs.$organizationSlug layout route. Any userId/organizationId that reaches these services from org-scoped routes has already been validated. Apply this pattern across all org-scoped services to avoid redundant auth checks and maintain consistency.
Applied to files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
📚 Learning: 2026-03-29T19:16:28.864Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3291
File: apps/webapp/app/v3/featureFlags.ts:53-65
Timestamp: 2026-03-29T19:16:28.864Z
Learning: When reviewing TypeScript code that uses Zod v3, treat `z.coerce.*()` schemas as their direct Zod type (e.g., `z.coerce.boolean()` returns a `ZodBoolean` with `_def.typeName === "ZodBoolean"`) rather than a `ZodEffects`. Only `.preprocess()`, `.refine()`/`.superRefine()`, and `.transform()` are expected to wrap schemas in `ZodEffects`. Therefore, in reviewers’ logic like `getFlagControlType`, do not flag/unblock failures that require unwrapping `ZodEffects` when the input schema is a `z.coerce.*` schema.
Applied to files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
📚 Learning: 2026-06-09T16:27:26.195Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3878
File: apps/webapp/app/v3/services/computeTemplateCreation.server.ts:0-0
Timestamp: 2026-06-09T16:27:26.195Z
Learning: When working in triggerdotdev/trigger.dev code related to worker-group/region default resolution (e.g., defaultWorkerInstanceGroupId handling used by getGlobalDefaultWorkerGroup, getDefaultWorkerGroupForProject, and RegionsPresenter), do NOT add org-level featureFlags overrides in only one resolution site. That can cause template creation routing/decisions to diverge from actual run routing. If org-level override of the default region/worker group is required, it must be centralized in getGlobalDefaultWorkerGroup so every resolution path remains aligned.
Applied to files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
📚 Learning: 2026-05-05T09:38:02.512Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3523
File: apps/webapp/app/routes/api.v3.batches.ts:178-181
Timestamp: 2026-05-05T09:38:02.512Z
Learning: When reviewing code that catches `ServiceValidationError` in `*.server.ts` files, do not blindly forward `error.status` to HTTP responses, because SVEs may be thrown with non-default statuses (e.g., 400/500) and forwarding them can cause client-visible behavioral regressions (e.g., surfacing 500s to clients). Prefer a safe default response status of `error.status ?? 422`, but only after confirming via the reachable call graph that the caught `ServiceValidationError` instances are expected to carry those non-default statuses; otherwise, normalize to `422` to avoid unexpected client-visible 5xx behavior.
Applied to files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.
Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.
Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.
Applied to files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
📚 Learning: 2026-06-25T18:21:51.905Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-revoke.tsx:0-0
Timestamp: 2026-06-25T18:21:51.905Z
Learning: During the Zod v4 migration in the triggerdotdev/trigger.dev webapp, ensure any imports from `conform-to/zod` use the Zod-4 subpath: `conform-to/zod/v4` (e.g., `import { parseWithZod } from "conform-to/zod/v4"`). Do not import from the package root `conform-to/zod`, because it is the Zod 3 implementation and may load Zod-3-only symbols (e.g., `ZodBranded`, `ZodEffects`), which can throw at module load (notably with `zod4.4.3`). This should be enforced across `apps/webapp/**/*` where helpers like `parseWithZod` and `conformZodMessage` are used.
Applied to files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
📚 Learning: 2026-07-03T17:10:21.498Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 4148
File: apps/webapp/app/models/orgMember.server.ts:149-168
Timestamp: 2026-07-03T17:10:21.498Z
Learning: In triggerdotdev/trigger.dev, `User.email` (Prisma schema: `internal-packages/database/prisma/schema.prisma`) currently does NOT use `citext` and does NOT have a `lower(email)` functional unique index. Therefore, do not introduce Prisma queries like `where: { email: { equals: <value>, mode: "insensitive" } }` (or any case-insensitive lookup) against `User.email`, because it can force sequential scans of the `users` table under load. During review, ensure email is normalized (e.g., lowercased/trimmed) before both writes and subsequent lookups, and if true case-insensitive behavior/uniqueness is required, implement it via a separate app-wide migration (e.g., switch to `citext` and/or add a functional unique index with backfill) rather than bolting it onto individual feature PRs.
Applied to files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
📚 Learning: 2026-05-14T08:21:07.614Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3614
File: apps/webapp/app/v3/mollifier/mollifierGate.server.ts:48-52
Timestamp: 2026-05-14T08:21:07.614Z
Learning: When using Trigger.dev v3 feature flags in the webapp, prefer the existing per-org gating mechanism supported by `flag()` via the `overrides` argument. Pass `Organization.featureFlags` (from `environment.organization.featureFlags`) as the `overrides` value; overrides must take precedence over the global `featureFlag` row. Do not require schema changes or add an `orgId` field to `FlagsOptions` for per-org gating—use the overrides pattern consistently (e.g., in gate flows like `resolveOrgFlag` and any server code that threads `environment.organization.featureFlags` into the gate call).
Applied to files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
📚 Learning: 2026-05-07T12:25:18.271Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3531
File: apps/webapp/test/sentryTraceContext.server.test.ts:9-47
Timestamp: 2026-05-07T12:25:18.271Z
Learning: In the triggerdotdev/trigger.dev webapp test suite, it is acceptable to leave `createInMemoryTracing()` calls that register a global `NodeTracerProvider` without `afterEach`/`afterAll` teardown. Do not flag this as a test-ordering risk when the code follows the established pattern used across webapp tests (e.g., replication service/benchmark/backfiller tests). This is considered safe because `trace.getActiveSpan()` when called outside a `context.with(...)` block reads `AsyncLocalStorage.getStore()` (undefined when no `run()` scope exists), so it falls back to `ROOT_CONTEXT` with no attached span—regardless of which provider is registered.
Applied to files:
apps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-05-28T20:02:10.647Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3772
File: apps/webapp/test/findOrCreateBackgroundWorker.test.ts:1-1
Timestamp: 2026-05-28T20:02:10.647Z
Learning: In the triggerdotdev/trigger.dev monorepo, for the `apps/webapp` package use the established convention of storing Vitest tests (unit, integration, and e2e) under `apps/webapp/test/` rather than colocating them next to source files. Do not flag files located in `apps/webapp/test/` as violating any rule that says to colocate tests with source.
Applied to files:
apps/webapp/test/billingLimitConvergeEnvironments.test.ts
🔇 Additional comments (10)
internal-packages/run-engine/src/run-queue/tests/dequeueMessageFromWorkerQueue.test.ts (1)
140-192: LGTM!internal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts (1)
1-80: LGTM!Also applies to: 81-454
apps/webapp/test/billingLimitConvergeEnvironments.test.ts (1)
14-32: LGTM!Also applies to: 84-96, 98-123
internal-packages/run-engine/src/engine/index.ts (1)
1637-1654: LGTM!internal-packages/run-engine/src/run-queue/index.ts (2)
1036-1147: LGTM!
5968-6007: LGTM!apps/webapp/app/v3/runQueue.server.ts (1)
33-48: LGTM!apps/webapp/app/v3/services/pauseEnvironment.server.ts (1)
5-5: LGTM!Also applies to: 111-135
apps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts (1)
32-41: LGTM!Also applies to: 57-82, 108-108, 176-177, 193-193
.server-changes/pause-returns-waiting-runs.md (1)
1-6: LGTM! Based on learnings,.server-changesentries should describe user-visible behavior without internal implementation details, which this entry does.
Comment on lines
+7
to
+11
| import { | ||
| removeQueueConcurrencyLimits, | ||
| returnUnclaimedMessagesToQueue, | ||
| updateQueueConcurrencyLimits, | ||
| } from "../runQueue.server"; |
Contributor
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Missing rollback on failure, unlike sibling pause paths.
If updateQueueConcurrencyLimits or the new returnUnclaimedMessagesToQueue call throws here, the outer catch just logs and returns success: false — but taskQueue.paused was already committed to true above, and there's no rollback. pauseEnvironment.server.ts and billingLimitConvergeEnvironments.server.ts both wrap the equivalent concurrency-update + returnUnclaimed sequence in an inner try/catch that reverts the DB pause state on error; this file lacks that, so a failed pause here can leave the queue marked paused in the DB while the caller is told the operation failed.
Consider wrapping the action === "paused" branch's two calls in a try/catch that reverts taskQueue.paused (and the concurrency limit, if previously unset) on failure, mirroring the other two pause flows.
Also applies to: 55-73
Comment on lines
+61
to
+62
| const calls: Array<{ concurrency?: number; returnedFor?: string }> = []; | ||
|
|
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win
Duplicate const calls declaration — will not compile.
The calls array is declared twice in a row with identical content, which is a duplicate const redeclaration in the same block scope and will fail TypeScript compilation.
🐛 Proposed fix
- const calls: Array<{ concurrency?: number; returnedFor?: string }> = [];
const calls: Array<{ concurrency?: number; returnedFor?: string }> = [];📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| const calls: Array<{ concurrency?: number; returnedFor?: string }> = []; | |
| const calls: Array<{ concurrency?: number; returnedFor?: string }> = []; |
… pause sweep Restore the TTL registration when returning a run. Admission removes the run's member from the TTL sorted set, so returning it to the pending queue without re-adding left a run that could never expire: on the next admission the dequeue script takes its already-expired branch, which deliberately leaves cleanup to the TTL consumer, and that consumer no longer has an entry to find. The per-run expireRun job is not a backstop because it is only armed for development environments. Take the pause sweep out of the rollback window. It ran inside the try that compensates a failed pause by clearing the DB flag, but by then the Redis limit was already 0, so a sweep failure left the environment with no concurrency and no paused flag — dark, and unrecoverable without a manual pause/resume cycle. For the billing-limit path it also aborted the remaining environments in the org. The pause is durable and the sweep is idempotent, so it now runs after the pause has been committed and a failure is logged rather than propagated. That also stops the queue pause reporting failure for a pause that took effect. Retry passes while runs remain unclaimed. Admission is not atomic with the push onto the worker queue: the dequeue script claims the concurrency slot and a separate round trip does the RPUSH. A run caught in that gap fails the claim and would previously have been abandoned, then executed during the pause. Claim from both the resolver-mapped and the raw worker queue key. The trigger- time fast path pushes to the raw workerQueue on the message while the master queue consumer pushes to the resolver-mapped one, so with a region override active the two producers disagree and a single-key LREM missed fast-pathed runs. Batch the sweep. It read every payload in one MGET and then made one sequential round trip per run, on a request path, with no error isolation — one failure abandoned the remaining runs. Tests: cover the LREM claim directly by emptying the worker queue without marking the run dequeued (the previous test was excluded by the candidate set before ever reaching the script), the TTL round trip, and the concurrency key running counter across a return.
…nestly Guard the pass count against non-finite input. Math.max(1, NaN) is NaN, so a NaN maxPasses skipped the loop entirely and reported a successful no-op sweep, and Infinity spun at one pass per 50ms inside an awaited request. The count is now clamped to a ceiling and falls back to the default when it is not finite. Retry a pass that errored, not just one that skipped. Rejected script calls never increment skipped, so a transient Redis failure part-way through a batch ended the sweep with those runs still admitted and still on the worker queue — the exact outcome the sweep exists to prevent — while the result read as a success with a non-zero error count nobody was gated on. Rename the residual count to skippedLastPass. It is the final pass's value rather than a total, and it conflates a run a worker claimed first (which escaped the pause and is executing) with a leaked concurrency slot that has no worker queue entry behind it. The name and its doc comment now say so instead of implying it partitions the candidate set alongside returned. Tests: pin the non-finite pass-count guard, cover that an acknowledged run is never resurrected by a later sweep, and stop the worker queue override test leaking its environment variable if the queue constructor throws.
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (3)
apps/webapp/app/v3/runQueue.server.ts (1)
62-76: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider surfacing partial sweeps above
debug.A sweep that completes with
errors > 0orskippedLastPass > 0means some admitted runs were not returned, which is the same user-visible outcome as a thrown failure but is only recorded atdebug. Awarnfor that case would make incomplete pauses observable in production.♻️ Suggested tweak
const result = await returnUnclaimedMessagesToQueue({ environment, queue }); - logger.debug("sweepUnclaimedRuns", { - environmentId: environment.id, - queue, - ...result, - }); + const payload = { environmentId: environment.id, queue, ...result }; + + if (result.errors > 0 || result.skippedLastPass > 0) { + logger.warn("sweepUnclaimedRuns did not fully settle", payload); + } else { + logger.debug("sweepUnclaimedRuns", payload); + }apps/webapp/test/pauseSweepWiring.test.ts (1)
25-30: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueBoth new test stubs encode an outdated
ReturnUnclaimedMessagesResultshape. The real contract resolves{ returned, skippedLastPass, errors, passes }, but both mocks returnskipped. Neither assertion reads the field, so this is silent drift rather than a failure.
apps/webapp/test/pauseSweepWiring.test.ts#L25-L30: renameskippedtoskippedLastPassin thereturnUnclaimedMessagesToQueuemodule stub.apps/webapp/test/sweepUnclaimedRuns.test.ts#L25-L30: renameskippedtoskippedLastPassin themockResolvedValueOncepayload.internal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts (1)
649-657: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valuePass the unclaimed retry budget explicitly in this test.
result.passesreflects the fallback/default pass count; a future change toRETURN_UNCLAIMED_MAX_PASSESwould make this assertion fail for the same retry behavior. AddmaxPasses: 2or assert against the exported/referenced retry setting instead of hard-coding2.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 784257a5-8986-4211-adc5-9678efbd825f
📒 Files selected for processing (10)
apps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.tsapps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsinternal-packages/run-engine/src/engine/index.tsinternal-packages/run-engine/src/run-queue/index.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts
🚧 Files skipped from review as they are similar to previous changes (3)
- internal-packages/run-engine/src/engine/index.ts
- apps/webapp/app/v3/services/billingLimit/billingLimitConvergeEnvironments.server.ts
- internal-packages/run-engine/src/run-queue/index.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (15)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (12, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (11, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 12)
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: typecheck / typecheck
- GitHub Check: internal / 🧪 Unit Tests: Internal
🧰 Additional context used
📓 Path-based instructions (13)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
**/*.{ts,tsx}: Prefer static imports over dynamicimport(); use dynamic imports only for unresolvable circular dependencies, genuine performance code splitting, or conditional runtime loading.
Import Trigger.dev tasks from@trigger.dev/sdk; never use@trigger.dev/sdk/v3or deprecatedclient.defineJob.
Add agentcrumbs while writing code using approved namespaces; mark lines with//@Crumbsor blocks with `// `#region` `@crumbs, and strip them before merging.
Files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
Files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
**/*.{test,spec}.{ts,tsx}: Use Vitest exclusively and never mock dependencies; use Testcontainers for integration dependencies.
Place test files next to the source files they test.
Files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: Access environment variables through theenvexport ofenv.server.tsinstead of directly accessingprocess.env
Use subpath exports from@trigger.dev/corepackage instead of importing from the root@trigger.dev/corepathDo not reintroduce the removed v1 execution path;
RunEngineVersion.V1branches may only reject or finalize gracefully so v3 clients receive a clean 4xx, never a 5xx.
Files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
apps/webapp/**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
Do not import
env.server.tsdirectly or indirectly into test files; instead pass environment-dependent values through options/parameters to make code testable
Files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
apps/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
For apps, use
typecheckfor verification and never usebuildas the correctness check.
Files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
apps/webapp/**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
Test files must not import
app/env.server.ts; pass configuration as options instead.
Files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
apps/webapp/app/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
apps/webapp/app/**/*.{ts,tsx}: For dashboard changes, visually verify the running Remix app with Chrome DevTools MCP, using snapshots, screenshots, interaction, and console-message checks as appropriate.
UseuseCallbackanduseMemoonly for context provider values, expensive derived data used as a dependency, or stable references required by dependency arrays; do not wrap ordinary event handlers or trivial computations.
Use named constants for sentinel or placeholder values instead of scattering raw string literals across comparisons.
Files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.ts
apps/webapp/app/**/*.ts
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
apps/webapp/app/**/*.ts: Never userequest.signalto detect client disconnects. UsegetRequestAbortSignal()fromapp/services/httpAsyncStorage.server.ts, which is wired to Express response close events.
Access environment variables through theenvexport fromapp/env.server.ts; never useprocess.envdirectly.
Always use PrismafindFirstinstead offindUnique.
Always use the$transactionhelper from~/db.server, never callprisma.$transactionor$replica.$transactiondirectly. Pass isolation levels as strings, useSerializablefor correctness-critical read-then-write invariants, and guard possibly undefined helper results when a definite value is required.
Files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.ts
apps/webapp/app/v3/**/*.ts
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
New code must target Run Engine V2 through the singleton in
app/v3/runEngine.server.ts; do not reintroduce V1 execution paths. V1 branches may only reject or finalize gracefully with a clean 4xx.
Files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.ts
internal-packages/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
For internal packages, use
typecheckfor verification and never usebuildas the correctness check.
Files:
internal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.ts
🧠 Learnings (21)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-05-07T12:25:18.271Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3531
File: apps/webapp/test/sentryTraceContext.server.test.ts:9-47
Timestamp: 2026-05-07T12:25:18.271Z
Learning: In the triggerdotdev/trigger.dev webapp test suite, it is acceptable to leave `createInMemoryTracing()` calls that register a global `NodeTracerProvider` without `afterEach`/`afterAll` teardown. Do not flag this as a test-ordering risk when the code follows the established pattern used across webapp tests (e.g., replication service/benchmark/backfiller tests). This is considered safe because `trace.getActiveSpan()` when called outside a `context.with(...)` block reads `AsyncLocalStorage.getStore()` (undefined when no `run()` scope exists), so it falls back to `ROOT_CONTEXT` with no attached span—regardless of which provider is registered.
Applied to files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-05-28T20:02:10.647Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3772
File: apps/webapp/test/findOrCreateBackgroundWorker.test.ts:1-1
Timestamp: 2026-05-28T20:02:10.647Z
Learning: In the triggerdotdev/trigger.dev monorepo, for the `apps/webapp` package use the established convention of storing Vitest tests (unit, integration, and e2e) under `apps/webapp/test/` rather than colocating them next to source files. Do not flag files located in `apps/webapp/test/` as violating any rule that says to colocate tests with source.
Applied to files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.
Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.
Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.
Applied to files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-06-25T18:21:51.905Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-revoke.tsx:0-0
Timestamp: 2026-06-25T18:21:51.905Z
Learning: During the Zod v4 migration in the triggerdotdev/trigger.dev webapp, ensure any imports from `conform-to/zod` use the Zod-4 subpath: `conform-to/zod/v4` (e.g., `import { parseWithZod } from "conform-to/zod/v4"`). Do not import from the package root `conform-to/zod`, because it is the Zod 3 implementation and may load Zod-3-only symbols (e.g., `ZodBranded`, `ZodEffects`), which can throw at module load (notably with `zod4.4.3`). This should be enforced across `apps/webapp/**/*` where helpers like `parseWithZod` and `conformZodMessage` are used.
Applied to files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-07-03T17:10:21.498Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 4148
File: apps/webapp/app/models/orgMember.server.ts:149-168
Timestamp: 2026-07-03T17:10:21.498Z
Learning: In triggerdotdev/trigger.dev, `User.email` (Prisma schema: `internal-packages/database/prisma/schema.prisma`) currently does NOT use `citext` and does NOT have a `lower(email)` functional unique index. Therefore, do not introduce Prisma queries like `where: { email: { equals: <value>, mode: "insensitive" } }` (or any case-insensitive lookup) against `User.email`, because it can force sequential scans of the `users` table under load. During review, ensure email is normalized (e.g., lowercased/trimmed) before both writes and subsequent lookups, and if true case-insensitive behavior/uniqueness is required, implement it via a separate app-wide migration (e.g., switch to `citext` and/or add a functional unique index with backfill) rather than bolting it onto individual feature PRs.
Applied to files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsapps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
apps/webapp/test/pauseSweepWiring.test.tsapps/webapp/test/sweepUnclaimedRuns.test.tsinternal-packages/run-engine/src/run-queue/tests/returnUnclaimedMessagesToQueue.test.tsapps/webapp/test/billingLimitConvergeEnvironments.test.ts
📚 Learning: 2026-03-10T17:56:20.938Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3201
File: apps/webapp/app/v3/services/setSeatsAddOn.server.ts:25-29
Timestamp: 2026-03-10T17:56:20.938Z
Learning: Do not implement local userId-to-organizationId authorization checks inside org-scoped service classes (e.g., SetSeatsAddOnService, SetBranchesAddOnService) in the web app. Rely on route-layer authentication (requireUserId(request)) and org membership enforcement via the _app.orgs.$organizationSlug layout route. Any userId/organizationId that reaches these services from org-scoped routes has already been validated. Apply this pattern across all org-scoped services to avoid redundant auth checks and maintain consistency.
Applied to files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/services/pauseQueue.server.ts
📚 Learning: 2026-03-29T19:16:28.864Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3291
File: apps/webapp/app/v3/featureFlags.ts:53-65
Timestamp: 2026-03-29T19:16:28.864Z
Learning: When reviewing TypeScript code that uses Zod v3, treat `z.coerce.*()` schemas as their direct Zod type (e.g., `z.coerce.boolean()` returns a `ZodBoolean` with `_def.typeName === "ZodBoolean"`) rather than a `ZodEffects`. Only `.preprocess()`, `.refine()`/`.superRefine()`, and `.transform()` are expected to wrap schemas in `ZodEffects`. Therefore, in reviewers’ logic like `getFlagControlType`, do not flag/unblock failures that require unwrapping `ZodEffects` when the input schema is a `z.coerce.*` schema.
Applied to files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.ts
📚 Learning: 2026-06-09T16:27:26.195Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3878
File: apps/webapp/app/v3/services/computeTemplateCreation.server.ts:0-0
Timestamp: 2026-06-09T16:27:26.195Z
Learning: When working in triggerdotdev/trigger.dev code related to worker-group/region default resolution (e.g., defaultWorkerInstanceGroupId handling used by getGlobalDefaultWorkerGroup, getDefaultWorkerGroupForProject, and RegionsPresenter), do NOT add org-level featureFlags overrides in only one resolution site. That can cause template creation routing/decisions to diverge from actual run routing. If org-level override of the default region/worker group is required, it must be centralized in getGlobalDefaultWorkerGroup so every resolution path remains aligned.
Applied to files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.ts
📚 Learning: 2026-05-05T09:38:02.512Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3523
File: apps/webapp/app/routes/api.v3.batches.ts:178-181
Timestamp: 2026-05-05T09:38:02.512Z
Learning: When reviewing code that catches `ServiceValidationError` in `*.server.ts` files, do not blindly forward `error.status` to HTTP responses, because SVEs may be thrown with non-default statuses (e.g., 400/500) and forwarding them can cause client-visible behavioral regressions (e.g., surfacing 500s to clients). Prefer a safe default response status of `error.status ?? 422`, but only after confirming via the reachable call graph that the caught `ServiceValidationError` instances are expected to carry those non-default statuses; otherwise, normalize to `422` to avoid unexpected client-visible 5xx behavior.
Applied to files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.ts
📚 Learning: 2026-05-14T08:21:07.614Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3614
File: apps/webapp/app/v3/mollifier/mollifierGate.server.ts:48-52
Timestamp: 2026-05-14T08:21:07.614Z
Learning: When using Trigger.dev v3 feature flags in the webapp, prefer the existing per-org gating mechanism supported by `flag()` via the `overrides` argument. Pass `Organization.featureFlags` (from `environment.organization.featureFlags`) as the `overrides` value; overrides must take precedence over the global `featureFlag` row. Do not require schema changes or add an `orgId` field to `FlagsOptions` for per-org gating—use the overrides pattern consistently (e.g., in gate flows like `resolveOrgFlag` and any server code that threads `environment.organization.featureFlags` into the gate call).
Applied to files:
apps/webapp/app/v3/services/pauseEnvironment.server.tsapps/webapp/app/v3/runQueue.server.tsapps/webapp/app/v3/services/pauseQueue.server.ts
🔇 Additional comments (3)
apps/webapp/app/v3/services/pauseEnvironment.server.ts (1)
5-5: LGTM!Also applies to: 139-142
apps/webapp/app/v3/services/pauseQueue.server.ts (1)
9-9: LGTM!Also applies to: 80-83
apps/webapp/test/billingLimitConvergeEnvironments.test.ts (1)
98-129: LGTM!
Member
|
@matt-aitken does this handle scheduled worker queues? |
The guard that stops a returned message being written back when its payload is gone was described as cleaning up an orphaned list entry. It is load-bearing: an acknowledgement landing between the candidate read and the script leaves a claimable worker queue entry whose run has already completed, and without the guard the sweep would put that completed run back on the pending queue. Also aligns two test doubles with the renamed result field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gap
Queuing happens in two phases. Phase 1 checks concurrency and admits runs; phase 2 is a plain FIFO list in Redis per worker region that supervisors drain.
Pausing a queue or an environment only sets its concurrency limit to
0. That correctly stops phase 1 admitting anything new — both the master-queue dequeue and the trigger-time fast path check the limit — but it does nothing about runs phase 1 had already admitted. Those are sitting in the worker queue, and the pop path is a bareBLPOPwith no pause or concurrency check, so they went on to execute during the pause.The exposure is bigger than it first looks. A worker-queue entry already holds a concurrency slot, so the ceiling is the queue's whole concurrency limit — and for an idle environment with headroom the trigger-time fast path pushes straight to the worker queue, so a burst can fill it before you can hit pause.
The fix
RunQueue.returnUnclaimedMessagesToQueue({ env, queue? })moves runs that have been admitted but not yet claimed by a worker back into the pending queue.Finding them doesn't need a scan of the region-wide list. A run in the worker queue is in
currentConcurrencybut not yet incurrentDequeued(that's only added at pop), so the difference of those two sets is exactly the candidate set. The worker-queue element itself only carries org + run id, so filtering the list directly wasn't an option anyway.Each move is a single Lua script, and the
LREMis the claim: if it removes nothing, a worker has already popped that entry and owns the run, so every other key is left untouched.BLPOPand the follow-up payload read are two separate round trips, so there's a window where a run is in neither the list norcurrentDequeuedand will show up as a candidate — keying off theLREMreturn value is what makes that race safe instead of a double dispatch.Three things the script has to get right beyond the claim:
message.timestamp.nackMessagere-scores tonow + backoff, which would reorder, so this deliberately doesn't reuse it.expireRunjob isn't a backstop; it's only armed for development environments.workerQueueon the message while the master-queue consumer pushes to the resolver-mapped one, so with a region override active the two producers disagree. The claim LREMs both.The ordering constraint
Returning a run costs it its place in the worker queue FIFO, and it can only re-enter at the back. So if the queue can still admit work, a newer run can overtake one on its way back, no matter how correct the re-scoring is. This is only safe once the concurrency limit is
0, and the doc comments say so. All three callers set the limit first.Failure handling
The sweep runs after the pause is committed, never inside the rollback window. Earlier it sat inside the try that compensates a failed pause by clearing the DB flag — but the Redis limit was already
0by then, so a sweep failure left the environment with no concurrency and no paused flag: dark, and unrecoverable without a manual pause/resume cycle. The pause is durable and the sweep is idempotent, so a failure is now logged rather than propagated.The sweep makes up to two passes. Admission isn't atomic with the push onto the worker queue — the dequeue script claims the slot and a separate round trip does the RPUSH — so a run caught in that gap fails its claim on the first pass and is claimable on the second. A pass that errored retries too: rejected script calls never increment the skipped count, so without that a transient Redis blip would end the sweep with those runs still admitted.
skippedLastPassis deliberately named: it's the final pass's residual, and it can't distinguish a run a worker claimed first (escaped the pause, executing now) from a leaked concurrency slot with no worker-queue entry behind it.Callers
Tests
returnUnclaimedMessagesToQueue.test.ts(16 cases): runs returned with concurrency released; original score and dequeue order preserved; a claimed run left alone; the LREM claim exercised directly by emptying the worker queue without marking the run dequeued; TTL round trip; concurrency-key queues including the length and running counters; fast-path enqueues; the dual worker-queue-key claim under a region override; retry-pass behaviour and the non-finitemaxPassesguard; an acknowledged run never resurrected; env-wide vs single-queue scope; cross-queue and cross-environment isolation; no-op and idempotency.dequeueMessageFromWorkerQueue.test.tsgains a case pinning thecurrentConcurrency/currentDequeuedinvariant the sweep relies on — it wasn't asserted anywhere.Webapp:
pauseSweepWiring.test.ts(sweep fires after the limit is zeroed, not on resume),sweepUnclaimedRuns.test.ts(a failing sweep can't fail a pause), and three more cases on the billing-converge path.Full
run-queuesuite is 127 green; engine dequeuing/ttl/priority suites pass.Key behaviours were mutation-tested rather than assumed: removing the dual-key LREM, the retry loop, the CK
lengthCounterINCR, the non-finite pass guard, and the sweep call site each fail a specific test. Two earlier tests that passed vacuously were found that way and rewritten.Not in this PR
RUN_ENGINE_WORKER_QUEUE_OVERRIDESwhile the master-queue consumer honours it, so fast-pathed runs land on the un-rerouted worker queue during a region migration. Pre-existing routing bug; the sweep compensates for itself but the bug wants its own fix.PauseQueueServicehas no rollback if its concurrency-limit write fails, unlikePauseEnvironmentService. Pre-existing.nackMessagedoesn'tLREMthe worker queue the wayacknowledgeMessagedoes. Currently unreachable because nack is only called post-pop, but it would be a duplicate-dispatch bug if that changed.Note
Touches
run-queue/index.ts, which #4367 is also editing. The changes are additive and in a different part of the file (two new Lua commands + a new method), but worth a heads-up on merge order.