gh-151907: Reduce duplication in codegen comprehension functions - #154846
Open
cdce8p wants to merge 2 commits into
Open
gh-151907: Reduce duplication in codegen comprehension functions#154846cdce8p wants to merge 2 commits into
cdce8p wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that #151908 updated both
codegen_sync_comprehension_generatorandcodegen_async_comprehension_generatorbut missed a spot to use the "new" helpercodegen_unpack_starredin the latter. After looking more closely into it, I noticed that a large part is actually identical between both functions. Moving it to a separate functions avoids any unintended differences between sync and async comprehensions just because on code path wasn't updated properly._Also added two
assert(!avoid_creation);to the helper which were added to the async variant but missed for the sync one./CC @ZeroIntensity