gh-154791: Fix asyncio Future losing traceback on repeated result() call - #154798
Open
iaroslavkrasikov wants to merge 3 commits into
Open
gh-154791: Fix asyncio Future losing traceback on repeated result() call#154798iaroslavkrasikov wants to merge 3 commits into
iaroslavkrasikov wants to merge 3 commits into
Conversation
iaroslavkrasikov
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
July 28, 2026 03:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #30274 fixed repeating traceback frames in
asyncio.Futureby storing tracebacks separately from exceptions infut_exception_tb. However, it also addedPy_CLEAR(fut->fut_exception_tb)infuture_get_result()after the firstresult()call. This means any subsequentawait/result()raises withPyException_SetTraceback(exc, None), losing traceback frames.The
_PyFutureimplementation never clears_exception_tband has always behaved correctly. This change makes the C implementation match.The reference cycle concern motivating the
Py_CLEARis already covered:fut_exception_tbis registered inFutureObj_traverse, so GC can collect any cycle through it.