ext/gmp: expose the possibility of being a prime in gmp_prevprime - #22907
Open
LamentXU123 wants to merge 2 commits into
Open
ext/gmp: expose the possibility of being a prime in gmp_prevprime#22907LamentXU123 wants to merge 2 commits into
gmp_prevprime#22907LamentXU123 wants to merge 2 commits into
Conversation
arnaud-lb
approved these changes
Jul 28, 2026
arnaud-lb
left a comment
arnaud-lb
left a comment
Member
There was a problem hiding this comment.
Thank you! This looks good to me otherwise, but please wait for other reviewers
Co-authored-by: Arnaud Le Blanc <365207+arnaud-lb@users.noreply.github.com>
arnaud-lb
approved these changes
Jul 28, 2026
Member
Author
|
@mbeccati @arnaud-lb Ah, the first version of gmp_prevprime already goes into alpha3... Should I add a NEWS entry under the beta section to clarify this change? Oh, why this just happens to be in the middle of releases, why... |
Contributor
|
@LamentXU123 If you think the change is worth to highlight sure. But then again, it's just an alpha version, so it depends on how much you care. |
Member
Author
|
This is a huge change to the function. So in this logic we should. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #22807 cc @arnaud-lb