standard: various nit and refactorings for standard stream wrappers - #22875
Open
Girgias wants to merge 4 commits into
Open
standard: various nit and refactorings for standard stream wrappers#22875Girgias wants to merge 4 commits into
Girgias wants to merge 4 commits into
Conversation
…esponse_headers_parse()
- Use newer zend_string APIs - Make logic more explicit and understandable - Prevent some strlen() recomputations
devnexen
reviewed
Jul 28, 2026
| } | ||
| /* check for control characters in login, password & path */ | ||
| if (strncasecmp(new_path, "http://", sizeof("http://") - 1) || strncasecmp(new_path, "https://", sizeof("https://") - 1)) { | ||
| if (zend_string_starts_with_literal_ci(new_path, "http://") || zend_string_starts_with_literal_ci(new_path, "https://")) { |
Member
There was a problem hiding this comment.
it seems the old condition was always true regardless ? I would either drop the "migrated" version of it or
if (!zend_string_starts_with_literal_ci(new_path, "http://") && !zend_string_starts_with_literal_ci(new_path, "https://"))
```. wdyt ?
Member
Author
There was a problem hiding this comment.
I'm... not even sure what the semantics are. Reading the rest of the code it does seem to me that it expects the path to start with an HTTP protocol schema....
As we are passing new_path to php_stream_url_wrap_http_ex
| php_stream_wrapper_log_warn(wrapper, context, options, InvalidUrl, \ | ||
| "Invalid redirect URL! %s", new_path); \ | ||
| "Invalid redirect URL! %s", ZSTR_VAL(new_path)); \ | ||
| efree(new_path); \ |
Member
There was a problem hiding this comment.
If I follow well, this needs an update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.