[bug]Message fields incorrectly deleted from GCS logs - #2844
Merged
Conversation
Fix bug in `(*GCSLogEntry).UnmarshalJSON` where `[mM]essage` fields where always deleted, even in non-ETW cases. This prevented the actual `kmsg` logs (where are added as `message` in log entries) from being correctly logged by the shim. Also: - remove trailing spaces in `init` dmesg logs. - increase `/dev/kmsg` read buffer and add comments about size. - trim trailing spaces (and newline) from parsed kmsg messages. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
rawahars
approved these changes
Jul 30, 2026
anmaxvl
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug in
(*GCSLogEntry).UnmarshalJSONwhere[mM]essagefields where always deleted, even in non-ETW cases.This prevented the actual
kmsglogs (where are added asmessagein log entries) from being correctly logged by the shim.Also:
initdmesg logs./dev/kmsgread buffer and add comments about size.