ADD: Get student by id method. - #2
Open
Icd-Kohi wants to merge 4 commits into
Open
Conversation
Remove unused `Optional` import. Alter
`@PutMapping("/editStudents/{id}")` to
`@PutMapping("/editStudent/{id}")`. Delete redundant annotation argument
`@PathVariable("id") long id` to `@PathVariable long id`.
Implement `StudentNotFoundException` if a non existant user id request is made. Implement helper exception handler `GlobalExceptionHandler`.
Icd-Kohi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Having a the possibility to request the student by its id is useful and it further enhance the API usability.
After implementing a new endpoint and method, it was necessary to handle the exception of a non existent student id request.
Changes in the codebase
controller/StudentController.java,entity/Student.java,repository/StudentRepository.java,service/StudentService.javaandservice/StudentServiceImpl.javafiles were modified.New implementation of
StudentNotFoundExceptionandGlobalExceptionHandlerwere added inexception/.Aditional information
Response of requesting a non existent student:
{ "instance": "/api/getStudent/3", "status": 404, "title": "Student not found.", "Student id: ": 3 }Response of requesting a existent student:
{ "address": "road one", "email": "mary@gmail.com", "id": 4, "name": "mary" }