Skip to content

Harden cli-test workflow against script injection #4483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickrolfe merged 1 commit into from
Jul 28, 2026
Merged

Harden cli-test workflow against script injection #4483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/cli-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,18 @@ jobs:
id: choose-ref
shell: bash
run: |
if [[ "${{ matrix.version }}" == "nightly" ]]
if [[ "$CLI_VERSION" == "nightly" ]]
then
REF="codeql-cli/latest"
else
REF="codeql-cli/${{ matrix.version }}"
# Validate the version read from supported_cli_versions.json before
# using it, to guard against script injection from untrusted input.
if [[ ! "$CLI_VERSION" =~ ^v?[0-9]+\.[0-9]+\.[0-9]+$ ]]
then
echo "Unexpected CLI version: '$CLI_VERSION'" >&2
exit 1
fi
REF="codeql-cli/$CLI_VERSION"
fi
echo "ref=$REF" >> "$GITHUB_OUTPUT"

Expand Down