ENT-14319: Added function to initialize promise-type/-module-projects - #198
Open
SimonThalvorsen wants to merge 1 commit into
Open
ENT-14319: Added function to initialize promise-type/-module-projects#198SimonThalvorsen wants to merge 1 commit into
SimonThalvorsen wants to merge 1 commit into
Conversation
|
Thank you for submitting a PR! Maybe @craigcomstock can review this? |
olehermanse
self-requested a review
July 28, 2026 13:36
SimonThalvorsen
marked this pull request as draft
July 28, 2026 17:06
olehermanse
marked this pull request as ready for review
July 29, 2026 12:37
olehermanse
reviewed
Jul 29, 2026
olehermanse
reviewed
Jul 29, 2026
olehermanse
reviewed
Jul 29, 2026
olehermanse
reviewed
Jul 29, 2026
olehermanse
reviewed
Jul 29, 2026
olehermanse
reviewed
Jul 29, 2026
olehermanse
reviewed
Jul 29, 2026
olehermanse
reviewed
Jul 29, 2026
olehermanse
reviewed
Jul 29, 2026
olehermanse
reviewed
Jul 29, 2026
|
|
||
| body file control | ||
| {{ | ||
| namespace => "{namespace}"; |
Member
There was a problem hiding this comment.
I don't think it's necessary to use a namespace here. You could have a __main__ bundle as the only bundle, or optionally have a test_example_name bundle for testing it.
Contributor
Author
There was a problem hiding this comment.
When not using namespace I could not get the bundling in the cfbs build/provides to work. I then had to manually run the file if I wanted to test
Member
There was a problem hiding this comment.
I think that issue stems from trying to do the same in build and provides. Fundamentally you want 2 different things;
- provides : Allow others to add your module, with the module doing nothing until they start using it.
- build : Build and test the module with some dummy policy which your users will not need / want.
olehermanse
reviewed
Jul 29, 2026
olehermanse
reviewed
Jul 29, 2026
olehermanse
requested changes
Jul 29, 2026
olehermanse
left a comment
olehermanse
left a comment
Member
There was a problem hiding this comment.
Looks good so far, left some suggestions / feedback. Will have more when I test it.
Ticket: ENT-14319 Changelog: None Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: ENT-14319
Changelog: None