feat(BRE2-1008): architecture / arm support - #134
Merged
Conversation
patelspratik
force-pushed
the
armsupport
branch
2 times, most recently
from
July 29, 2026 16:35
3a0d97f to
2dcd9b7
Compare
Contributor
Author
|
quota failure on nebius |
drewmalin
reviewed
Jul 29, 2026
Comment on lines
+583
to
+585
| if strings.Contains(platformLower, "b300") { | ||
| return "B300", "B300" | ||
| } |
Contributor
There was a problem hiding this comment.
Do we have a bug here where we would capture gb300s here?
Contributor
Author
There was a problem hiding this comment.
yes, this is what lead to me finding that there were gb300s to begin with :D. Will fix. Also adding gb200s.
| if strings.Contains(platformLower, "b200") { | ||
| return "compute.instance.gpu.b200" | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
We will need the new types here as well so that we can query for quota, e.g.:
if strings.Contains(platformLower, "gb300") {
return "compute.instance.gpu.gb300"
}
if strings.Contains(platformLower, "b300") {
return "compute.instance.gpu.b300"
}
if strings.Contains(platformLower, "rtx6000") {
return "compute.instance.gpu.rtx6000"
}I think this will make the test pass as we look like we're bailing after not finding quota
Contributor
Author
There was a problem hiding this comment.
I'm going to add gb200s as well, as that is also missing
drewmalin
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.