Feature/test with linux clang 23 - #304
Merged
Merged
Conversation
This seems to force linker errors with import std;
(and documenting the workaround) until LLVM fixes the underlying problem.
(for Clang only needed) Prevent Clang -Werror or fixed them too
* Fix typo in GNUmakefile * Fix ThreadSanitizer Error: data race * update requirements.txt * Disable BEMAN_BUILDSYS_SANITIZER in preset This seems to force linker errors with import std; * Bump workflows to 1.7.4 * Clang++ and CXX_MODULES can not work with libstdc++
There was a problem hiding this comment.
Pull request overview
Updates build tooling and CI configuration to validate this project with newer Linux Clang (v23) and expanded module/import std experimentation, while cleaning up warnings in tests/examples and adjusting infra/toolchain integration.
Changes:
- Expand CI matrix and workflow versions to test newer compiler/toolchain combinations (including module-enabled presets).
- Adjust CMake toolchain/modules support for
import std;and libc++ (including experimental CMake UUID handling). - Silence newly-triggered warnings in tests/examples and add developer build conveniences (GNUmakefile, ignore
.init).
Reviewed changes
Copilot reviewed 22 out of 24 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/beman/execution/non_assignable.test.cpp | Silence unused-variable warnings via [[maybe_unused]] to keep tests warning-clean. |
| tests/beman/execution/exec-dependent-sender.test.cpp | Silence unused lambda parameter warnings in compile-time assertions. |
| tests/beman/execution/exec-continues-on.test.cpp | Mark unused local variable to avoid warnings. |
| tests/beman/execution/exec-affine.test.cpp | Warning suppression tweaks and a TODO related to Clang warnings. |
| tests/beman/execution/CMakeLists.txt | Disable TSan for a specific Clang test target. |
| requirements.txt | Update tooling versions and adjust installation hint; tweak internal tooling entries. |
| Makefile | Bump local toolchain hints/paths to newer LLVM/GCC versions. |
| infra/cmake/llvm-libc++-toolchain.cmake | Adjust libc++ toolchain flags (including fortify defines). |
| infra/cmake/enable-experimental-import-std.cmake | Add experimental import std UUID for newer CMake versions. |
| infra/.beman_submodule | Bump infra submodule commit hash. |
| include/beman/execution/detail/task_scheduler.hpp | Add virtual destructor to polymorphic base. |
| include/beman/execution/detail/counting_scope_join.hpp | Add TODO comment near sender creation. |
| GNUmakefile | Add new GNU Make-based developer workflow wrapper around CMake presets/ninja. |
| examples/stopping.cpp | Add mutex + guarded output to reduce interleaved output/data-race issues. |
| CMakePresets.json | Adjust sanitizer and module preset defaults. |
| CMakeLists.txt | Simplify module build configuration by removing some shared/DLL quickfix logic. |
| cmake/README.md | Remove CMake helper documentation file. |
| cmake/prelude.cmake | Adjust experimental import std gating and libc++/modules-json probing logic. |
| cmake/cxx-modules-rules.cmake | Change extensions default and add warning-suppression flags for Clang modules builds. |
| .gitignore | Ignore .init marker file created by GNUmakefile workflow. |
| .github/workflows/pre-commit-update.yml | Bump reusable workflow version. |
| .github/workflows/pre-commit-check.yml | Bump reusable workflow version and add explicit permissions. |
| .github/workflows/ci_tests.yml | Bump reusable workflow versions, adjust schedule/concurrency, expand test matrices. |
| .beman-tidy.yaml | Ignore .cache/ in tidy configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+68
to
73
| add_compile_options( | ||
| $ENV{CXXFLAGS} | ||
| -Wno-missing-braces | ||
| -Wno-unneeded-internal-declaration | ||
| ) | ||
| add_link_options($ENV{CXXFLAGS}) |
Comment on lines
+34
to
+37
| compile_commands.json: $(_build_path)/compile_commands.json | ||
| if [ "X$(shell readlink compile_commands.json)" != "X$(_build_path)/compile_commands.json" ] ; then \ | ||
| ln -fs $< $@; \ | ||
| fi |
Comment on lines
90
to
+94
| elseif(LINUX) | ||
| set(ENV{CXXFLAGS} | ||
| "-stdlib=libc++ -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0" | ||
| ) | ||
| message(STATUS "CXXFLAGS=$ENV{CXXFLAGS}") |
Comment on lines
18
to
+22
| if(NOT CMAKE_CXX_FLAGS MATCHES "-stdlib=libc\\+\\+") | ||
| string(APPEND CMAKE_CXX_FLAGS " -stdlib=libc++") | ||
| string( | ||
| APPEND CMAKE_CXX_FLAGS | ||
| " -stdlib=libc++ -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0" | ||
| ) |
|
coverage: 93.518%. remained the same — feature/test-with-linux-clang-23 into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.