Skip to content

[To dev/1.3] [Pipe] Release tablet memory before closing TsFile scan parser (#18350) - #18354

Open
Caideyipi wants to merge 1 commit into
apache:dev/1.3from
Caideyipi:cp-a6ac4cb-dev-1.3
Open

[To dev/1.3] [Pipe] Release tablet memory before closing TsFile scan parser (#18350)#18354
Caideyipi wants to merge 1 commit into
apache:dev/1.3from
Caideyipi:cp-a6ac4cb-dev-1.3

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

Backport #18350 (a6ac4cba687a98a1dbc0babe72f590da9ce9be8f) to dev/1.3.

  • Defer closing the TsFile scan container until the final tablet's memory has been released.
  • Close immediately when initialization finds no readable chunk.
  • Add regression coverage that verifies allocated tablet memory is zero before the memory block is closed.

The dev/1.3 branch still uses TsFileInsertionScanDataContainer, so the parser and test names were adapted to the older container API while preserving the original behavior.

Verification

  • mvn -o -nsu spotless:apply -pl iotdb-core/datanode
  • mvn -o -nsu -pl iotdb-core/datanode '-Dtest=TsFileInsertionDataContainerTest#testScanContainerReleasesTabletMemoryAfterRawTabletGenerated' test (1 test passed, 0 failures)

This PR has:

  • been self-reviewed.
  • added or modified unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant