Subscription: preserve topic updates during owner transfer - #18353
Open
Caideyipi wants to merge 1 commit into
Open
Subscription: preserve topic updates during owner transfer#18353Caideyipi wants to merge 1 commit into
Caideyipi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
An owner-transfer request built its full updated
TopicMetabefore waiting for the previous owner's lease to expire. While that request was waiting, anotherALTER TOPICcould update attributes such ascolumn-filter. A delayed or retried owner-transfer request would then submit its pre-wait snapshot and restore the old attributes.Fix
TopicMetaand merge only the attributes from the owner-transfer request.Validation
mvn spotless:apply -pl iotdb-core/confignodemvn -pl iotdb-core/confignode -am -Dtest=SubscriptionCoordinatorTest -Dsurefire.failIfNoSpecifiedTests=false testIoTDBConsensusSubscriptionColumnFilterClusterITwas skipped during cluster setup because the local template contained mixed DataNode classes (NoSuchMethodError: IoTDBConfig.isEnableWhiteList()), before the test body ran.This PR has:
Key changed/added classes
SubscriptionCoordinatorSubscriptionCoordinatorTest