fix(material/chips): update chips minimum touch target to 48px - #33570
Open
essjay05 wants to merge 4 commits into
Open
fix(material/chips): update chips minimum touch target to 48px#33570essjay05 wants to merge 4 commits into
essjay05 wants to merge 4 commits into
Conversation
essjay05
force-pushed
the
mat-chips-min-touch-target-fix
branch
from
July 23, 2026 00:39
5cfdb4e to
0a385ea
Compare
essjay05
added
the
dev-app preview
|
Deployed dev-app for 9a178fe to: https://ng-dev-previews-comp--pr-angular-components-33570-dev-ox14cqnq.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
crisbeto
approved these changes
Jul 25, 2026
crisbeto
requested changes
Jul 25, 2026
Updates Angular Components' Chips component so that chips use a touch-target span similar to buttons to ensure that chips meet the minimum touch-target size of 48x48 for accessibility standards. Fixes b/537441584
Updates previous changes to fix lint errors.
essjay05
force-pushed
the
mat-chips-min-touch-target-fix
branch
from
July 27, 2026 16:18
0a385ea to
f85696c
Compare
Updates previous changes to Angular Components' Chip component to add a touch-target element and modifies the previously implemented styles to follow the density logic applied to touch-target theme/styles for checkbox and button. Fixes b/537441584
Updates previous changes to remove unused scss variable that I added for my original solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Angular Components' Chips component so that chips use a touch-target span similar to buttons to ensure that chips meet the minimum touch-target size of 48x48 for accessibility standards.
Fixes b/537441584