Skip to content

Fix for as.IDate() to retain names even before some as.Date() calls did so in R (4.1.2) - #7850

Merged
ben-schwen merged 1 commit into
masterfrom
as-date-names-old-r
Jul 29, 2026
Merged

Fix for as.IDate() to retain names even before some as.Date() calls did so in R (4.1.2)#7850
ben-schwen merged 1 commit into
masterfrom
as-date-names-old-r

Conversation

@MichaelChirico

@MichaelChirico MichaelChirico commented Jul 27, 2026

Copy link
Copy Markdown
Member

Follow-up to #7800 for pre-R-4.1.2 behavior of as.Date.POSIXlt.

@MichaelChirico MichaelChirico changed the title always copy_names() in as.IDate for POSIXct Fix for as.IDate() to retain names even before some as.Date() calls did so in R (4.1.2) Jul 27, 2026
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.01%. Comparing base (dcaa87c) to head (9888866).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7850   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          88       88           
  Lines       17286    17286           
=======================================
  Hits        17116    17116           
  Misses        170      170           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
  • HEAD=as-date-names-old-r much slower for as.data.table.array improved in #7019
    Comparison Plot

Generated via commit 9888866

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 49 seconds
Installing different package versions 1 minutes and 34 seconds
Running and plotting the test cases 6 minutes and 29 seconds

@MichaelChirico
MichaelChirico force-pushed the as-date-names-old-r branch 2 times, most recently from 965fc12 to d8bb200 Compare July 28, 2026 00:06
@MichaelChirico
MichaelChirico force-pushed the fix-latvian-tests branch 2 times, most recently from d7cf097 to 5b56eb4 Compare July 28, 2026 02:04
@MichaelChirico
MichaelChirico force-pushed the fix-latvian-tests branch 2 times, most recently from 417989b to e093b6f Compare July 28, 2026 20:15
@MichaelChirico
MichaelChirico changed the base branch from fix-latvian-tests to master July 28, 2026 20:49
@ben-schwen
ben-schwen merged commit c751c14 into master Jul 29, 2026
22 checks passed
@ben-schwen
ben-schwen deleted the as-date-names-old-r branch July 29, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants