Skip to content

Get other.Rraw running again in r-devel - #7833

Merged
MichaelChirico merged 12 commits into
masterfrom
other-attach-order
Jul 29, 2026
Merged

Get other.Rraw running again in r-devel#7833
MichaelChirico merged 12 commits into
masterfrom
other-attach-order

Conversation

@MichaelChirico

@MichaelChirico MichaelChirico commented Jul 23, 2026

Copy link
Copy Markdown
Member

A few changes here:

  • We need to mess with the attach order. Originally tried attach.required=FALSE but that's not present on R 3.5.0.
  • {ggplot2} internals have moved around again. I think the intent of those tests is just to ensure print(<ggplot-obj>) works without error, so switched those to use the new check_value=FALSE.
  • Robustness improvement for a {bit64} test when lacking proper long double. I'm of half a mind to just delete that test because it's only testing {bit64} functionality anyway...
  • Since RFC: fail test.data.table() if non-test code produces warnings #7210, warning() outside of test() is caught, so change an intentional warning on Windows to cat().

Split off from #7832 as the actual debugging of package code should be done artisinally.

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.01%. Comparing base (dcaa87c) to head (dbaea75).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7833   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          88       88           
  Lines       17286    17286           
=======================================
  Hits        17116    17116           
  Misses        170      170           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
  • HEAD=other-attach-order much slower for transform improved in #5493
    Comparison Plot

Generated via commit 4db2f8f

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 47 seconds
Installing different package versions 1 minutes and 9 seconds
Running and plotting the test cases 5 minutes and 34 seconds

@MichaelChirico MichaelChirico changed the title Use attach.required=FALSE to solve "ggplot not found" error in other.Rraw Fix attach order for other.Rraw Jul 23, 2026
@MichaelChirico MichaelChirico changed the title Fix attach order for other.Rraw Get other.Rraw running again in r-devel Jul 23, 2026
Comment thread inst/tests/other.Rraw
Comment thread inst/tests/other.Rraw Outdated
@MichaelChirico
MichaelChirico changed the base branch from master to test-check-value July 26, 2026 17:01
Base automatically changed from test-check-value to master July 26, 2026 18:34
@MichaelChirico

This comment was marked as outdated.

@MichaelChirico
MichaelChirico force-pushed the other-attach-order branch 2 times, most recently from f1edc68 to 4db2f8f Compare July 28, 2026 20:15
@MichaelChirico
MichaelChirico changed the base branch from master to example-local-redux July 28, 2026 20:18
@MichaelChirico
MichaelChirico changed the base branch from example-local-redux to master July 28, 2026 20:50

@ben-schwen ben-schwen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelChirico
MichaelChirico merged commit accac97 into master Jul 29, 2026
20 of 24 checks passed
@MichaelChirico
MichaelChirico deleted the other-attach-order branch July 29, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants