Get other.Rraw running again in r-devel - #7833
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7833 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 88 88
Lines 17286 17286
=======================================
Hits 17116 17116
Misses 170 170 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Generated via commit 4db2f8f Download link for the artifact containing the test results: ↓ atime-results.zip
|
MichaelChirico
force-pushed
the
other-attach-order
branch
from
July 24, 2026 06:05
5dde771 to
58ce9c4
Compare
ben-schwen
reviewed
Jul 25, 2026
ben-schwen
reviewed
Jul 25, 2026
MichaelChirico
force-pushed
the
other-attach-order
branch
from
July 26, 2026 16:53
179a522 to
9972feb
Compare
MichaelChirico
force-pushed
the
other-attach-order
branch
from
July 26, 2026 17:55
9972feb to
f2a0220
Compare
MichaelChirico
force-pushed
the
test-check-value
branch
from
July 26, 2026 17:55
6553c92 to
05b83d1
Compare
MichaelChirico
force-pushed
the
other-attach-order
branch
from
July 26, 2026 20:46
f2a0220 to
75ec5b2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
MichaelChirico
force-pushed
the
other-attach-order
branch
2 times, most recently
from
July 28, 2026 20:15
f1edc68 to
4db2f8f
Compare
MichaelChirico
force-pushed
the
other-attach-order
branch
from
July 28, 2026 20:25
4db2f8f to
4c5621e
Compare
…are size instead.
MichaelChirico
force-pushed
the
other-attach-order
branch
from
July 28, 2026 20:46
4c5621e to
dbaea75
Compare
MichaelChirico
force-pushed
the
example-local-redux
branch
from
July 28, 2026 20:46
c66b7b0 to
5cd4000
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

A few changes here:
attach.required=FALSEbut that's not present on R 3.5.0.print(<ggplot-obj>)works without error, so switched those to use the newcheck_value=FALSE.long double. I'm of half a mind to just delete that test because it's only testing {bit64} functionality anyway...test.data.table()if non-test code produces warnings #7210,warning()outside oftest()is caught, so change an intentional warning on Windows tocat().Split off from #7832 as the actual debugging of package code should be done artisinally.