Skip to content

Upgrade Rails to fix security issues - #943

Merged
zetter-rpf merged 1 commit into
mainfrom
upgrade-rails
Jul 30, 2026
Merged

Upgrade Rails to fix security issues#943
zetter-rpf merged 1 commit into
mainfrom
upgrade-rails

Conversation

@zetter-rpf

Copy link
Copy Markdown
Contributor

This is to patch [CVE-2026-66066] in activestorage

This is to patch [CVE-2026-66066] in activestorage
Copilot AI review requested due to automatic review settings July 30, 2026 07:42
@cla-bot cla-bot Bot added the cla-signed label Jul 30, 2026
@zetter-rpf
zetter-rpf marked this pull request as ready for review July 30, 2026 07:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the application’s Rails dependency to a patched 8.1.x release in order to address the Active Storage security issue referenced in the PR description (CVE-2026-66066).

Changes:

  • Bump the Rails gem requirement from ~> 8.1.3 to ~> 8.1.3.1.
  • Update Gemfile.lock so all Rails framework components (including activestorage) resolve to 8.1.3.1.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
Gemfile Updates the Rails version constraint to ~> 8.1.3.1.
Gemfile.lock Locks Rails and related framework gems (incl. Active Storage) to 8.1.3.1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown

Test coverage

92.18% line coverage reported by SimpleCov.
Run: https://github.com/RaspberryPiFoundation/editor-api/actions/runs/30524070845

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ab10583. Configure here.

Comment thread Gemfile
gem 'rack_content_type_default', '~> 1.1'
gem 'rack-cors'
gem 'rails', '~> 8.1.3'
gem 'rails', '~> 8.1.3.1'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible Heroku boot failure risk

High Severity

Rails 8.1.3.1 makes Active Storage raise a RuntimeError at boot when ruby-vips is present and system libvips is older than 8.13. This app declares ruby-vips and runs on Heroku; heroku-22 still ships libvips 8.12.x, so a deploy on that stack can fail to start after this upgrade.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ab10583. Configure here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run Vips.version_string on production and got "8.15.1" back

@raspberrypiherokubot
raspberrypiherokubot temporarily deployed to editor-api-p-upgrade-ra-kswu2t July 30, 2026 07:53 Inactive
@zetter-rpf
zetter-rpf merged commit ecff8c4 into main Jul 30, 2026
7 checks passed
@zetter-rpf
zetter-rpf deleted the upgrade-rails branch July 30, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants