Remove the MessageFailuresUpdated notification chain - #5664
Open
johnsimons wants to merge 1 commit into
Open
Conversation
This system was responsible for tracking and broadcasting updates about failed message counts (unresolved and archived). It is no longer consumed by any UI component (e.g., ServicePulse) or other parts of ServiceControl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5659 removed SignalR, including the
IUserInterfaceEventmarker that selected which domain events got broadcast. It stopped at the marker, soMessageFailuresUpdatedsurvived, along with everything that exists to produce it. That event only ever had one sink, and it was the SignalR hub.With
ServicePulseNotifiergone, nothing handles it. There is noIDomainHandler<MessageFailuresUpdated>anywhere insrc, and it falls through all three catch-allIDomainHandler<IDomainEvent>handlers:IntegrationEventWriterdispatches to 12EventPublisher<TEvent, TDispatchContext>implementations.Handlesis@event is TEvent, and none of the 12 event types match, so it is never published externally.AuditEventLogWriterlooks the event up inEventLogMappings, an exactGetType()dictionary keyed by the registered definitions. None of the 23 registered definitions is for this event, so no log item is written.ServicePulseNotifierno longer exists.So the whole chain now computes two counts, raises an event, and drops it on the floor.
No client is affected. ServicePulse takes its failed message counts from the
Total-Countheader on the errors endpoints and always has. The SignalR event was a nudge, never the data source.