fix(supervisor-network): redact FORWARD query strings in OCSF and denials - #2531
Closed
Ayush7614 wants to merge 1 commit into
Closed
fix(supervisor-network): redact FORWARD query strings in OCSF and denials#2531Ayush7614 wants to merge 1 commit into
Ayush7614 wants to merge 1 commit into
Conversation
…ials Emit-site hardening so query secrets never land in on-disk OCSF/shorthand logs or client-facing 403 bodies; defense-in-depth read-path redaction remains. Signed-off-by: Ayush7614 <ayushknj3@gmail.com>
Ayush7614
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
July 28, 2026 21:28
|
Thank you for your interest in contributing to OpenShell, @Ayush7614. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
Collaborator
|
This should largely be covered by #2510 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden FORWARD HTTP proxy emit sites so query-string secrets never land in on-disk OCSF/shorthand logs or client-facing 403 bodies. Read-path denial redaction remains as defense-in-depth.
Related Issue
N/A — direct fix for a documented emit-site gap (previously only mitigated on the agent-facing denial read path). No open/closed/merged issue or PR covered this.
Changes
redact_path_for_logging/redact_uri_for_logginghelpers (?[redacted]marker)parse_proxy_urierror messages so secrets cannot leak via{e}policy_localcomment to reflect emit-site hardeningarchitecture/security-policy.mdTesting
mise run pre-commitpasses (misenot available in this environment;cargo fmt --checkclean for touched crate)cargo test -p openshell-supervisor-network --libforredact_*,parse_proxy_uri_errors_do_not_embed_query_secrets,ocsf_url_from_redacted_path_keeps_marker_not_secret, and existingtest_parse_proxy_uri*)Checklist