Skip to content

GitHub Issue #159: Require all assay transform scripts to reside in container's @scripts dir - #7895

Open
cnathe wants to merge 6 commits into
developfrom
fb_assayTransform159
Open

GitHub Issue #159: Require all assay transform scripts to reside in container's @scripts dir#7895
cnathe wants to merge 6 commits into
developfrom
fb_assayTransform159

Conversation

@cnathe

@cnathe cnathe commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Rationale

https://github.com/LabKey/internal-issues/issues/159

Assay transform scripts configured through the designer must now live in the design's own container @scripts directory (writable only by platform developers), enforced by a new validateScriptLocation() in the save path, with a site-wide deprecated feature flag as an escape hatch and a usage metric approximating how many existing designs are non-compliant. The Selenium page object switches the default addTransformScript(File) to file-upload mode, deleting any same-named leftover from @scripts first.

Related Pull Requests

Changes

  • Add validateScriptLocation() call to make sure that assay transform script path is a child of the container's @scripts dir
  • Add optional feature flag to "turn off" the @scripts dir path validation check
  • Metric for approximate count of assay transform script paths that are not in an @scripts dir path

@cnathe
cnathe requested a review from labkey-klum July 30, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants