update elf.h from Debian Trixie musl-dev 1.2.5-3.1~deb13u1 - #29
Open
illwieckz wants to merge 3 commits into
Open
update elf.h from Debian Trixie musl-dev 1.2.5-3.1~deb13u1#29illwieckz wants to merge 3 commits into
illwieckz wants to merge 3 commits into
Conversation
Member
Author
|
Actually, two more commits related to ELF things can be merged beforehand. We can avoid relying on system I included them in the branch. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
elf.hfrom Debian Trixiemusl-dev 1.2.5-3.1~deb13u1.The breakpad merge of upstream requires newer ELF symbols. By updating this Musl
elf.hfile beforehand, we don't have to implement compat code at merge time, and it doesn't delay the fix for after the merge. On merge commit, all platforms that was working before the merge will find the updatedelf.hfile and miss no symbols.Actually it's possible to use that Musl
elf.hfile on every platform, and delete all the compatibility code, but upstream added more compatibility code instead of updating that file, so the NUKING of the compatibility code will happen after the merge.