Skip to content

Get rid of nacl_helper_bootstrap-armhf - #1998

Open
slipher wants to merge 2 commits into
DaemonEngine:masterfrom
slipher:no-bootstrap-bootstrap
Open

Get rid of nacl_helper_bootstrap-armhf#1998
slipher wants to merge 2 commits into
DaemonEngine:masterfrom
slipher:no-bootstrap-bootstrap

Conversation

@slipher

@slipher slipher commented Jul 30, 2026

Copy link
Copy Markdown
Member

Don't use a whole extra binary just to change the directory and set an environment variable. Use the actions provided by posix_spawn instead. Fixes #1336.

I'm aware this would create a rebase conflict with #1986 but this should make the implementation a lot cleaner. No more fork/exec of useless processes in the attempt to test whether multi-arch is supported. Instead you could just see whether the real bootstrap loader starts. I'm willing to rebase it myself.

Tested on a QEMU arm64 system. Note: it doesn't work if you set vm.nacl.bootstrap to 0, but that also doesn't work on master.

@illwieckz

Copy link
Copy Markdown
Member

Very nice! 🙂️

I would rather port your code myself over my branch at the place of least effort than to expect anyone to suffer the rebase of my branch over this… No one deserves that pain! 🫣️

@illwieckz

Copy link
Copy Markdown
Member

As a side note, my branch also had some minor rewrite of the chainloader and I was wondering if that chainloader could be imported in the native_client repository instead. 😁️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do we really need nacl_helper_bootstrap-armhf just to set an env var?

2 participants