Skip to content

[O2B-1601] Add feature to allow users to filter runs by beam type - #2200

Open
graduta wants to merge 4 commits into
mainfrom
feature/O2B-1601-add-beam-type-filter-to-run-overview
Open

[O2B-1601] Add feature to allow users to filter runs by beam type#2200
graduta wants to merge 4 commits into
mainfrom
feature/O2B-1601-add-beam-type-filter-to-run-overview

Conversation

@graduta

@graduta graduta commented Jul 29, 2026

Copy link
Copy Markdown
Member

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • on run-overview page, users are now able to select from the widget boxes and filter by the beam type associated to the fill of that run.

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 46.20%. Comparing base (1758c68) to head (81b6299).

Files with missing lines Patch % Lines
...blic/views/Runs/ActiveColumns/runsActiveColumns.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2200      +/-   ##
==========================================
+ Coverage   46.17%   46.20%   +0.02%     
==========================================
  Files        1038     1039       +1     
  Lines       17123    17131       +8     
  Branches     3122     3123       +1     
==========================================
+ Hits         7907     7915       +8     
  Misses       9216     9216              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@isaachilly isaachilly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filter is called PDP Beam Type but its options and related filtering in the useCase is all related to beamType, as is the PR description but not the ticket description. I don't know which way around it's meant to be but I think right now they are at loggerheads?

@graduta

graduta commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

The filter is called PDP Beam Type but its options and related filtering in the useCase is all related to beamType, as is the PR description but not the ticket description. I don't know which way around it's meant to be but I think right now they are at loggerheads?

You are absolutely right! The PDP Beam Type, which is an environment configurable parameter is next filter I will add. While the values correspond to the same idea, they contain different values. Thank you for noticing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants